Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue: enable vue on ci #73

Merged
merged 1 commit into from
Aug 31, 2022
Merged

vue: enable vue on ci #73

merged 1 commit into from
Aug 31, 2022

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Aug 26, 2022

No description provided.

@jbedard jbedard requested a review from alexeagle August 26, 2022 22:07
@alexeagle
Copy link
Member

It fails because it has no tests. You could just add a build_test as a placeholder, though the fact that we have a bug filed against this example suggests we should have a real test for the bundle output.

@jbedard
Copy link
Member Author

jbedard commented Aug 26, 2022

Yeah I forgot you mentioned that earlier. I'd like to add at least a basic test instead of just building it

@alexeagle alexeagle removed their request for review August 29, 2022 17:18
@jbedard
Copy link
Member Author

jbedard commented Aug 31, 2022

@alexeagle I think I'd like to merge this now just to get it running on CI and I'll create a task for adding tests...

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, small steps
Are always better

@jbedard jbedard merged commit 22510e2 into aspect-build:main Aug 31, 2022
@jbedard
Copy link
Member Author

jbedard commented Aug 31, 2022

#77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants