Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: ability to exclude subsets of fetched npm packages #2042

Closed
jbedard opened this issue Dec 17, 2024 · 1 comment · Fixed by #2078
Closed

[FR]: ability to exclude subsets of fetched npm packages #2042

jbedard opened this issue Dec 17, 2024 · 1 comment · Fixed by #2078
Labels
enhancement New feature or request

Comments

@jbedard
Copy link
Member

jbedard commented Dec 17, 2024 •
edited
Loading

What is the current behavior?

Many packages ship with unnecessary content such as tests, test data etc that must then be copied throughout actions.

Describe the feature

An API to enable excluding files from the package target so they don't get copied around within bazel.

The excluding would most likely be done post-extraction to ensure the package on disk is the exactly as downloaded, only the bazel targets wrapping that package will contain the exclusions.
@jbedard jbedard added the enhancement New feature or request label Dec 17, 2024
@alexeagle
Copy link
Member

alexeagle commented Dec 18, 2024 •
edited
Loading

As an example, 295efe3 shows how to exclude from a package using lifecycle hooks. Was needed to workaround this error:

ERROR: /workspaces/rt_development/BUILD.bazel:6:22: Running lifecycle hooks on npm package [email protected]_t2g22a3cflk65wz3kqpekiolbu failed: error traversing directory '@@aspect_rules_js~~npm~npm_deps__nodegit__0.28.0-alpha.11__t2g22a3cflk65wz3kqpekiolbu//:package': Error while traversing directory package/vendor/libgit2/tests/resources/status: /home/rt_user/.cache/bazel/_bazel_rt_user/d851f08fd6ebe652ee1e63dd37aa0d3d/external/aspect_rules_js~~npm~npm_deps__nodegit__0.28.0-alpha.11__t2g22a3cflk65wz3kqpekiolbu/package/vendor/libgit2/tests/resources/status/这 (No such file or directory)

@Mivr Mivr mentioned this issue Jan 27, 2025
Merged
jbedard pushed a commit that referenced this issue Feb 6, 2025
@Mivr
feat: add exclude patterns for npm packages (#2078)
ef8e187 
### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: yes
- Breaking change (forces users to change their own code or config): no
- Suggested release notes appear below: yes

Add `npm_translate_lock(exclude_package_contents)` and `npm_import(exclude_package_contents)` for excluding content when extracting packages.

### Test plan

- New test added: e2e/package_exclude_patterns

Resolves: #2042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add exclude patterns for npm packages Mivr/rules_js
2 participants
@alexeagle @jbedard