Skip to content

Conversation

bthmc
Copy link

@bthmc bthmc commented Aug 22, 2025

Nickel is a configuration language: https://github.com/tweag/nickel
This change adds formatting .ncl files with the nickel CLI.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

"Format .ncl files with the nickel CLI"

Test plan

  • New test cases added

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


bthmc seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

aspect-workflows bot commented Aug 22, 2025

Test

1 test target passed

Targets
//format/test:ls-files_test [k8-fastbuild] 616ms

Total test execution time was 616ms. 3 tests (75.0%) were fully cached saving 747ms.


Test

docs

3 test targets passed

Targets
//:update_10_test [k8-fastbuild]           35ms
//:update_11_test [k8-fastbuild]           107ms
//:update_8_test [k8-fastbuild]            93ms

Total test execution time was 235ms. 12 tests (80.0%) were fully cached saving 573ms.


Test

example

9 test targets passed

Targets
//tools/format:format_js_test_JavaScript_with_prettier [k8-fastbuild]266ms
//tools/format:format_js_test_Markdown_with_prettier [k8-fastbuild]166ms
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]7s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]2s
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]815ms
//tools/format:format_test_Python_with_ruff [k8-fastbuild]185ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]1s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]3s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]230ms

Total test execution time was 15s. 25 tests (73.5%) were fully cached saving 11s.


Test (WORKSPACE) (Test)

example

9 test targets passed

Targets
//tools/format:format_js_test_JavaScript_with_prettier [k8-fastbuild]227ms
//tools/format:format_js_test_Markdown_with_prettier [k8-fastbuild]152ms
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]7s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]1s
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]963ms
//tools/format:format_test_Python_with_ruff [k8-fastbuild]221ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]2s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]4s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]242ms

Total test execution time was 17s. 9 tests (50.0%) were fully cached saving 8s.


Lint [.]      Lint [docs]      Lint [example]

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, are you looking at the test failures?

@bthmc
Copy link
Author

bthmc commented Aug 28, 2025

The error seems to be a external issue:

(17:28:38) ERROR: /mnt/ephemeral/output/rules_lint/example/external/bazel_tools/tools/build_defs/repo/http.bzl:136:45: An error occurred during the fetch of repository 'ape~':
   Traceback (most recent call last):
	File "/mnt/ephemeral/output/rules_lint/example/external/bazel_tools/tools/build_defs/repo/http.bzl", line 136, column 45, in _http_archive_impl
		download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://gitlab.arm.com/bazel/ape/-/releases/v1.0.1/downloads/src.tar.gz] to /mnt/ephemeral/output/rules_lint/example/external/ape~/temp4691302944205049403/src.tar.gz: GET returned 502 Bad Gateway
(17:28:54) WARNING: Download from https://gitlab.arm.com/bazel/rules_diff/-/releases/v1.0.0/downloads/src.tar.gz failed: class java.io.IOException GET returned 502 Bad Gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants