Skip to content

Commit

Permalink
chore: flip no legacy external runfiles (#193)
Browse files Browse the repository at this point in the history
### Type of change

- Chore (any other change that doesn't affect source or test files, such
as configuration)

### Test plan

- New test cases added

It seems like this issue has already been fixed, I flipped the flag for
future cases.

closes #152
  • Loading branch information
thesayyn authored Mar 3, 2024
1 parent 734070b commit 2950c0c
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ common --incompatible_enable_cc_toolchain_resolution
# Use local rules_python
# Enable with --config=dev
common:dev --override_repository=rules_python=~/workspace/rules_python
# No external runfiles
common --nolegacy_external_runfiles


# Load any settings specific to the current user.
# .bazelrc.user should appear in .gitignore so that settings are not shared with team members
Expand Down
9 changes: 9 additions & 0 deletions examples/py_binary/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
load("//py:defs.bzl", "py_binary")

py_binary(
name = "py_binary",
srcs = ["say.py"],
deps = [
"@pypi_cowsay//:pkg",
],
)
3 changes: 3 additions & 0 deletions examples/py_binary/say.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import cowsay

cowsay.cow('hello py_binary!')
9 changes: 8 additions & 1 deletion gazelle_python.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ manifest:
colorama.tests.winterm_test: colorama
colorama.win32: colorama
colorama.winterm: colorama
cowsay: cowsay
cowsay.characters: cowsay
cowsay.main: cowsay
cowsay.tests: cowsay
cowsay.tests.solutions: cowsay
cowsay.tests.test_api: cowsay
cowsay.tests.test_output: cowsay
django: Django
django.apps: Django
django.apps.config: Django
Expand Down Expand Up @@ -946,4 +953,4 @@ manifest:
typing_extensions: typing_extensions
pip_repository:
name: pypi
integrity: f553566eaf30557a41499dc599ab31526aa68e77f5cee73ed0da29d6c02bedfd
integrity: bda699f1c32ae76fb0df4861571379f69bfd240f131217fc47553f0af4e6d085
1 change: 1 addition & 0 deletions requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ django~=4.2.7
colorama~=0.4.0
click
pytest
cowsay
3 changes: 3 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ colorama==0.4.6 \
--hash=sha256:08695f5cb7ed6e0531a20572697297273c47b8cae5a63ffc6d6ed5c201be6e44 \
--hash=sha256:4f1d9991f5acc0ca119f9d443620b77f9d6b33703e51011c16baf57afb285fc6
# via -r requirements.in
cowsay==6.1 \
--hash=sha256:274b1e6fc1b966d53976333eb90ac94cb07a450a700b455af9fbdf882244b30a
# via -r requirements.in
django==4.2.10 \
--hash=sha256:a2d4c4d4ea0b6f0895acde632071aff6400bfc331228fc978b05452a0ff3e9f1 \
--hash=sha256:b1260ed381b10a11753c73444408e19869f3241fc45c985cd55a30177c789d13
Expand Down

0 comments on commit 2950c0c

Please sign in to comment.