Skip to content

Commit

Permalink
fix: allow symlink collision error to be downgraded (#369)
Browse files Browse the repository at this point in the history
Introduces an attr allowing the symlink collision errors to be
downgraded to a warning or ignored.

Closes #358

---

### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: yes
- Breaking change (forces users to change their own code or config): yes
- Suggested release notes appear below:

Allow the "conflicting symlinks" error when creating a venv to be
downgraded to a warning and ignored.

### Test plan

- Manual testing; please provide instructions so we can reproduce:

Run `//py/tests/virtual/django:manage` with the `pyqt6` packages
installed.

---------

Co-authored-by: Alex Eagle <[email protected]>
  • Loading branch information
Matt Mackay and alexeagle authored Jul 19, 2024
1 parent 9730638 commit de35052
Show file tree
Hide file tree
Showing 24 changed files with 442 additions and 17,037 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ jobs:
- uses: actions/checkout@v4
- run: patch --dry-run -p1 < .bcr/patches/*.patch

test-release:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- working-directory: e2e/use_release
run: ./minimal_download_test.sh
# TODO(alex): enable after next release. Matt will yell at you if you forget.
# test-release:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - working-directory: e2e/use_release
# run: ./minimal_download_test.sh
Loading

0 comments on commit de35052

Please sign in to comment.