-
-
Notifications
You must be signed in to change notification settings - Fork 95
feat: add project-qualified hub labels @hub//project/<stamp>:<pkg> #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xangcastle
wants to merge
54
commits into
main
Choose a base branch
from
xangcastle/quilified-labels
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
8d3d897
add project-qualified hub labels @hub//project/<stamp>:<pkg>
xangcastle 06ce478
Merge branch 'main' into xangcastle/quilified-labels
xangcastle 58ce530
fix(py): exclude Tcl/Tk runtime libraries when exclude_feature=tkinte…
xangcastle 15c3c88
fix(uv): deduplicate whl_install wheel file labels (#1232)
jbedard 085595a
refactor(uv): remove redundant is_* indirection from ABI config setti…
jbedard 928e9f4
fix: unformatted error message (#1237)
jbedard 6e01a43
refactor: remove dead code (#1236)
jbedard 42751ca
perf(uv): use index cursors in PEP 508 tokenizer and parser (#1239)
jbedard 1d74a22
refactor: remove unused load()s in generated code (#1241)
jbedard 704e16c
refactor(py): remove dead code and unreachable paths (#1248)
jbedard 1834c16
chore: remove orphaned tools/e2e devserver (#1249)
jbedard b1725c7
fix(uv): correct GitHub archive URLs for git ref sources (#1238)
jbedard 5204fc2
refactor(uv): warn instead of silently skipping pyproject parsing wit…
jbedard c876f4c
fix: invalid error message on failure (#1245)
jbedard b9f3a3f
ci: use 32core for rules-proto-grpc-python e2e test (#1251)
jbedard 690804f
test: cover PEP 508 ~=/===/partial eval, dep_groups, and pytest_shard…
jbedard a631d3a
chore: upgrade aspect-cli to 2026.28.2
jbedard c54b612
refactor(uv): remove the unresolved uv toolchain type (#1250)
jbedard 0b6d7e8
fix(py_image_layer): wire PY_TOOLCHAIN through py_venv_exec so interp…
xangcastle 025c748
fix(uv): select C++ compiler companions (#1213)
tamird 79db931
test: cover py_pex_binary shebang, inherit_path, and constraint attrs…
jbedard c76bdc8
fix: correct two broken CLI error paths found in the dead-code audit …
jbedard dbb5287
refactor(uv): simplify no-op logic in whl_install repo rule (#1259)
jbedard 7515417
feat: Analysis benchmark (#1264)
xangcastle 06ce9b3
perf(uv): name uv_project targets without pure-Starlark sha1 (#1255)
jbedard f585d9c
refactor(uv): remove dead code and unreachable paths (#1260)
jbedard 31d4d94
chore: remove the unconsumed root requirements lockfile loop (#1266)
jbedard c9242bb
refactor(py_venv): dedupe winner-selection walk in collision resoluti…
jbedard 4071c50
refactor(py_venv): share provider construction between rule variants …
jbedard 547fda2
test: assert the freethreaded venv layout in freethreaded-805 (#1258)
jbedard ffabde1
test(uv): unit-cover parse_whl_name and version_util.is_decimal (#1261)
jbedard e587410
perf(uv): collapse abi tag config_setting_groups into config_settings…
jbedard 9771104
refactor(uv): alias cp* python-version constraints to their py* twins…
jbedard 2669911
refactor(uv): consolidate indent/url_basename/hash helpers (#1263)
jbedard 31e8616
perf(uv): derive SCC ids without hashing full SCC content (#1253)
jbedard 1763f00
chore: config hygiene — drop no-op flags, dead ci.bazelrc stanzas, tr…
jbedard 2ba1ea4
chore: remove orphaned test fixtures (#1272)
jbedard 92d2213
fix(pytest): expose main() from py_pytest_main-generated entrypoints …
jbedard 8364c55
fix: resolve py_image_layer.platform relative to the calling repo (#1…
jbedard bc9a851
perf(py_venv): precompute per-wheel collision claims in the wheel rec…
jbedard 60dcaf9
refactor(uv): make SCC computation linear and single-pass (#1246)
jbedard 279543d
fix(py_venv): merge colliding package directories (#1205)
tamird 6400ae4
chore: remove unused bazel/defs.bzl and empty bazel/patches (#1280)
jbedard 8212791
chore: remove unused tools scripts (#1282)
jbedard f227521
chore: delete unused code (#1281)
jbedard 4211c23
chore: checkin MODULE.bazel.lock files (#1278)
jbedard 54a69a8
perf(uv): expand wheel configurations once per distinct tag triple (#…
jbedard 0f0a215
perf(py_venv): build symlink target paths from a cached per-wheel pre…
jbedard ac3087e
refactor: simplify _resolve_wheel_collisions (#1283)
acozzette 400409f
add project-qualified hub labels @hub//project/<stamp>:<pkg>
xangcastle 8642c38
refactor: unify namespace entry merging across both all-namespace bra…
acozzette 16db162
Merge remote-tracking branch 'origin/xangcastle/quilified-labels' int…
xangcastle b036884
add project-qualified hub labels @hub//project/<stamp>:<pkg>
xangcastle e96964c
Merge remote-tracking branch 'origin/xangcastle/quilified-labels' int…
xangcastle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't like this magic hardcoded "project/" keyword and think this is an indication of a bad API. Is this bad API simply aligning with a python/pip/uv API and the alignment is more important then it being bad? Or is there a better way to do this without hardcoding a magci "project/" keyword?
@gregmagolan and I had a similar discussion in #977 where he was able to find a way to avoid such a keyword...