fix(uv): keep JDK paths valid during sdist builds#1289
Conversation
tamird
force-pushed
the
tamird/fix-py-binary-tool-env
branch
2 times, most recently
from
7025e2b to
44e79cd
Compare
tamird
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44e79cd090
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tamird
force-pushed
the
tamird/fix-py-binary-tool-env
branch
from
44e79cd to
f7e1cee
Compare
tamird
changed the title
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Replaced by #1295 |
1 participant
PEP 517 backends run from the unpacked sdist worktree, but
JAVABASE and JAVA expand to execroot-relative paths. Native Java
sdists such as pemja therefore see those paths stop resolving after
the cwd change.
Resolve the declared Java runtime paths before invoking the backend.
Remove the stale JAR fixture because current_java_runtime does not
declare that tool. Extend the native-wheel fixture to require
absolute, existing JAVA_HOME and JAVA.