fix(py): reset Python flags on data edges#1294
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
tamird
force-pushed
the
tamird/reset-data-dep-group-baseline
branch
from
38ec62c to
13b342d
Compare
|
@codex review |
tamird
force-pushed
the
tamird/reset-data-dep-group-baseline
branch
from
13b342d to
3edc667
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3edc667d6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tamird
force-pushed
the
tamird/reset-data-dep-group-baseline
branch
from
3edc667 to
0d9742e
Compare
tamird
changed the title
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d9742eef1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tamird
force-pushed
the
tamird/reset-data-dep-group-baseline
branch
from
0d9742e to
1a517c0
Compare
Data dependencies are runtime artifacts shared by callers in different Python environments. A terminal incoming transition carries its python_version and dep_group overrides into data, so each environment reanalyzes the same runtime subtree. Remember the exact settings inherited before terminal overrides and reset data edges to that baseline. Put Python-sensitive artifacts in deps so they retain the terminal configuration. Limit terminal transitions to attr-driven overrides; global-only interpreter feature settings remain inherited without copy-through. An analysis test counts configured probe outputs across real data edges, both override dimensions, and nested terminals.
tamird
force-pushed
the
tamird/reset-data-dep-group-baseline
branch
from
1a517c0 to
6d3350d
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d3350d1d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3 participants
Runtime data should not inherit a terminal-selected Python environment.
Otherwise the same data subtree is analyzed once per python_version or
dep_group.
Remember each raw setting inherited before a terminal override and reset
py_library, py_venv, and launcher data edges to that baseline. This
preserves nonempty caller settings and legacy-only rules_python version
configurations instead of hard-coding defaults. Artifacts whose analysis
must match the terminal Python environment belong in deps. Global-only
interpreter feature settings stay inherited without appearing on the
terminal transition surface.
An analysis test counts configured probe outputs across both override
dimensions, real data edges, and nested terminals.