Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (follow-up) use original interpreter path as 'home' value in pyv… #228

Closed
wants to merge 1 commit into from

Conversation

honnix
Copy link

@honnix honnix commented Nov 30, 2023

…env.cfg

This is a follow-up of #226 to fix another place.


Type of change

  • Bug fix (change which fixes an issue)

For changes visible to end-users

  • Suggested release notes are provided below:

Ensure correct home pathing is used when generating the venv.

Test plan

  • Manual testing; please provide instructions so we can reproduce:

As described by #226 (comment)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mattem
Copy link
Collaborator

mattem commented Dec 7, 2023

Thanks @honnix, are you able to sign the CLA?

@honnix
Copy link
Author

honnix commented Dec 8, 2023

Thanks @honnix, are you able to sign the CLA?

I will have to go through my employer so not sure how long it would take. Please feel free to pick up the change and discard this PR, as it is so small anyway :)

@honnix
Copy link
Author

honnix commented Dec 15, 2023

@mattem This is a somewhat annoying bug. To unblock the fix I will close this PR and please help fix it. Thank you!

@honnix honnix closed this Dec 15, 2023
@honnix honnix deleted the patch-1 branch December 15, 2023 08:39
@honnix
Copy link
Author

honnix commented Feb 22, 2024

Looks like this has not been solved. Could you please help fix it @mattem ? Thank you. NVM I got lost in recent changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants