chore: minimal changes required to upgrade to Bazel 7 and bzlmod #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Does this work with the new addition of rules_rust in #233? |
|
No idea - that does seem like a risk. We should clearly do both, so I think it's just a detail of which one lands first. |
|
Can we land the switch to Bazel 7 with bzlmod disabled? Need the Bazel 7 bump for the Python Starlark rules. |
|
Yeah that's the right thing anyway following "change one thing at a time" |
Will handle bzlmod in a follow-up
alexeagle
commented
Jan 11, 2024
alexeagle
commented
Jan 11, 2024
mattem
approved these changes
Jan 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a follow-up change I'll try to empty out the WORKSPACE file.
Also we need another change to add CI testing for other Bazel versions, assuming we decide to continue supporting Bazel 6 and have tests for it.
Type of change
For changes visible to end-users
This shouldn't be user-visible, it's only applicable when building within rules_py.
Test plan