fix: handle py_binary#main like rules_python does #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't love the semantics but it's better for us to follow our 'drop-in replacement' philosophy than explain to users how they're meant to change their code.
mattem
requested changes
Jan 12, 2024
alexeagle
force-pushed
the
py_binary-main
branch
from
90819ae to
8b21710
Compare
alexeagle
force-pushed
the
py_binary-main
branch
from
8b21710 to
4467cf6
Compare
alexeagle
force-pushed
the
py_binary-main
branch
from
d42ea28 to
4dd871d
Compare
use it to demonstrate how you can opt-out from rules_python semantics on the 'main' attribute
mattem
approved these changes
Jan 16, 2024
|
If I understand it correctly, the following code would stop working: py_pytest_main(
name = "__test__",
)
py_test(
name = "test_all",
srcs = glob(["**/*.py"]),
main = ":__test__.py",
deps = [":__test__", ...],
)and it should now be: py_pytest_main(
name = "__test__",
)
py_test(
name = "test_all",
srcs = glob(["**/*.py"]) + [":__test__"],
main = ":__test__.py",
deps = [...],
)Is that correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't love the semantics but it's better for us to follow our 'drop-in replacement' philosophy than explain to users how they're meant to change their code.
Type of change
Test plan