Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make py_binary#resolutions and py_test#resolutions identical. #487

Merged

Conversation

njlr
Copy link
Contributor

@njlr njlr commented Dec 19, 2024

Closes #466

  • Make resolutions consistent between py_binary and py_test
  • Allow a list to be passed to from_requirements
  • Add an example of virtual_deps feature

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below:
  • Fix: Make resolutions consistent between py_binary and py_test
  • Feature: Allow a list to be passed to from_requirements
  • Docs: Add an example of virtual_deps feature

Test plan

  • Manual testing; please provide instructions so we can reproduce: Added an example

njlr added 2 commits December 19, 2024 20:59
 - Allow a list to be passed to `from_requirements`
 - Add an example of `virtual_deps` feature
Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, great finding. It all looks good to me, while technically breaking change, we claimed that py_binary and py_test are identical, so this counts as a bug.

@thesayyn thesayyn changed the title bugfix/issue-466-py-test-resolutions-dx fix: make py_binary#resolutions and py_test#resolutions identical. Jan 21, 2025
@thesayyn
Copy link
Member

@njlr can you force push to kick the CI?

@thesayyn thesayyn merged commit 66bc9be into aspect-build:main Jan 22, 2025
14 checks passed
@thesayyn
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: py_test does not accept the same resolutions as py_binary
2 participants