Skip to content

Correctly compute the effective margin beyond the edge of the window #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correctly compute the effective margin beyond the edge of the window #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion smooth-scrolling.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ the logical line."
#'beginning-of-line))
(point)))

(defun smooth-scroll-count-lines (start end)
(defun smooth-scroll-count-lines-positive (start end)
"Return number of (logical/visual) lines between START and END.

If `smooth-scroll-strict-margins' is non-nil, this counts visual
Expand All @@ -199,6 +199,18 @@ to pass them in order."
#'count-lines)
start end)))

(defun smooth-scroll-count-lines (start end)
"Return number of (logical/visual) lines between START and END.

If `smooth-scroll-strict-margins' is non-nil, this counts visual
lines. Otherwise it counts logical lines.

If END is less than START, this can return a negative number."
(if (< end start)
(- (smooth-scroll-count-lines-positive end start))
(smooth-scroll-count-lines-positive start end)
))

(defun smooth-scroll-lines-above-point ()
"Return the number of lines in window above point.

Expand Down