Skip to content

Prepare for SYNERGY+#13

Open
timovdk wants to merge 33 commits into
asreview:mainfrom
timovdk:prepare-for-syn-plus
Open

Prepare for SYNERGY+#13
timovdk wants to merge 33 commits into
asreview:mainfrom
timovdk:prepare-for-syn-plus

Conversation

@timovdk
Copy link
Copy Markdown

@timovdk timovdk commented Apr 8, 2026

  • Support two sources (backwards compatibility for SYN1), you can set an environment variable to switch to SYN1, this is also used to decide between what code to use when creating the dataset.
  • Fix concept code, SYN1 had old openalex work objects, but concepts are deprecated, so we have to use the topics/domain/field system now. (but concept logic was retained for SYN1)
  • Fix concepts in metadata.json files (same as above, but then for creating review_metadata.csv and other CLI commands)
  • Add extensive tests
  • Add Pydantic validation (Created Models based on the OpenAlex API description to validate)
  • Add "extended" option to get command
  • Add flattening to complex fields (authorships is split into lists of authors etc.)
  • Set up train/test split
  • Setup URLs to the correct repositories

@timovdk timovdk requested review from EmilyWes and J535D165 April 9, 2026 11:41
Copy link
Copy Markdown

@EmilyWes EmilyWes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Nice work!
Added 2 comments, but after that I would say good to go :)

Comment thread synergy_dataset/__main__.py Outdated
Comment thread synergy_dataset/base.py Outdated
@timovdk
Copy link
Copy Markdown
Author

timovdk commented May 13, 2026

After a chat with Jonathan I decided to reduce the number of options that the new version of the package will support. This improves maintainability and makes it simpler to 'just' download synergy for a quick benchmark.

@timovdk timovdk requested review from EmilyWes and J535D165 and removed request for J535D165 May 13, 2026 07:48
@J535D165
Copy link
Copy Markdown
Member

Can you mark this ready for review?

@timovdk timovdk marked this pull request as ready for review May 13, 2026 13:00
Comment thread synergy_dataset/__main__.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants