suggested improvement to 'ignored' message #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
imo this can get too repetitive and deviates too much from standard test output. I'd recommend finding an existing issue or opening a new issue for us to brainstorm on how to improve this. |
|
It happened exactly the same to me. Is there any discussion issue or should I create one? |
|
#105 is the only ignored-related issue. If that is relevant, feel free to comment on there, otherwise feel free to create a new one |
|
I had this same issue. Didn't get it to work until seeing this thread |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #244, suggesting a slight change to "ignored". It took me some time to figure out why my tests weren't running, a slightly more informative message than "ignored" may save some time.