-
Notifications
You must be signed in to change notification settings - Fork 29
Change Notebooks to local installation of latest dev state #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 5 commits
bb25697
e4b1a83
7d8fbaa
6e79b21
4c3d177
bd3d367
3ca4eb7
3f5522a
0b5877a
8b36941
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,7 +82,6 @@ | |
| "IN_COLAB = importlib.util.find_spec(\"google.colab\") is not None\n", | ||
| "\n", | ||
| "if IN_COLAB:\n", | ||
| " !pip install assume-framework[learning]\n", | ||
| " # Colab currently has issues with pyomo version 6.8.2, causing the notebook to crash\n", | ||
| " # Installing an older version resolves this issue. This should only be considered a temporary fix.\n", | ||
| " !pip install pyomo==6.8.0" | ||
|
|
@@ -119,7 +118,8 @@ | |
| "outputs": [], | ||
| "source": [ | ||
| "if IN_COLAB:\n", | ||
| " !git clone --depth=1 https://github.com/assume-framework/assume.git assume-repo" | ||
| " !git clone --depth=1 https://github.com/assume-framework/assume.git assume-repo\n", | ||
| " !pip install -e ./assume-repo[learning]" | ||
|
||
| ] | ||
| }, | ||
| { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -166,7 +166,8 @@ | |
| "source": [ | ||
| "# Only run this cell if you are using Google Colab\n", | ||
| "if IN_COLAB:\n", | ||
| " !git clone --depth=1 https://github.com/assume-framework/assume.git assume-repo" | ||
| " !git clone --depth=1 https://github.com/assume-framework/assume.git assume-repo\n", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The installation command in the markdown cell still references the normal installation, there also with ". -e" then?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This happens in multiple tutorials. Please make changes accordingly. |
||
| " !pip install -e assume-repo" | ||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -1845,7 +1846,7 @@ | |
| ], | ||
| "metadata": { | ||
| "kernelspec": { | ||
| "display_name": "assume-framework", | ||
| "display_name": "assume", | ||
| "language": "python", | ||
| "name": "python3" | ||
| }, | ||
|
|
@@ -1859,7 +1860,7 @@ | |
| "name": "python", | ||
| "nbconvert_exporter": "python", | ||
| "pygments_lexer": "ipython3", | ||
| "version": "3.11.9" | ||
| "version": "3.12.11" | ||
| } | ||
| }, | ||
| "nbformat": 4, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,8 +79,6 @@ | |
| "# Check if 'google.colab' is available\n", | ||
| "IN_COLAB = importlib.util.find_spec(\"google.colab\") is not None\n", | ||
| "\n", | ||
| "if IN_COLAB:\n", | ||
| " !pip install assume-framework\n", | ||
| "!pip install matplotlib" | ||
| ] | ||
| }, | ||
|
|
@@ -98,7 +96,8 @@ | |
| "outputs": [], | ||
| "source": [ | ||
| "if IN_COLAB:\n", | ||
| " !git clone --depth=1 https://github.com/assume-framework/assume.git assume-repo" | ||
| " !git clone --depth=1 https://github.com/assume-framework/assume.git assume-repo\n", | ||
| " !pip install -e assume-repo" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adjust the comment above that the code does not need to be executed when one has the current dev state installed, not the release. |
||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -538,7 +537,7 @@ | |
| "name": "python", | ||
| "nbconvert_exporter": "python", | ||
| "pygments_lexer": "ipython3", | ||
| "version": "3.12.7" | ||
| "version": "3.12.11" | ||
| }, | ||
| "nbsphinx": { | ||
| "execute": "never" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not do this consistently, then, to avoid future errors? If we decide to install the dev state, do we always?