Skip to content

Conversation

@reinecfi
Copy link
Contributor

@reinecfi reinecfi commented Dec 16, 2025

Description

Currently obs_dim, foresight, unique_obs_dim are fixed values for a given strategy. As they are directly interdependent, obs_dim is now calculated based on the other ones. Adjustments should now only need less changes per strategy.

Also correcting some wrong values in the doc strings and removing the reward scaling in RenewableEnergyLearningSingleBidStrategy (as already done in EnergyLearningStrategy).

Checklist

  • Documentation updated (docstrings, READMEs, user guides, inline comments, doc folder updates etc.)
  • New unit/integration tests added (if applicable)
  • Changes noted in release notes (if any)
  • Consent to release this PR's code under the GNU Affero General Public License v3.0

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (8f7bd22) to head (5210f1c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
assume/strategies/learning_strategies.py 57.14% 3 Missing ⚠️
assume/reinforcement_learning/algorithms/matd3.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   81.31%   81.30%   -0.01%     
==========================================
  Files          54       54              
  Lines        8032     8035       +3     
==========================================
+ Hits         6531     6533       +2     
- Misses       1501     1502       +1     
Flag Coverage Δ
pytest 81.30% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would like to also wait for feedback from @kim-mskw

@kim-mskw kim-mskw self-requested a review December 19, 2025 14:12
Copy link
Contributor

@kim-mskw kim-mskw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice work @reinecfi. Please adjust the learning notebooks as well; they won't be functional if I am correct, and even if they should reflect the current implementation. I added release notes, noting that any other rationale for the obs_dim needs to be reconfigured in the learning strategy. Please add this explanation to the learning notebook as well.

kim-mskw and others added 2 commits December 22, 2025 10:44
…esight is subject to change

incorporated feedback from Isaac on the config file decription
added a couple comments to adress what Chiara wondered about
@reinecfi
Copy link
Contributor Author

reinecfi commented Dec 22, 2025

The notebooks should be up to date now.
@kim-mskw Thanks for the updated documentation, I think the additions might be quite helpful.

reinecfi and others added 2 commits December 22, 2025 16:48
- add obs_dim calcualtion explanation to 04b and 04c
@kim-mskw kim-mskw self-requested a review December 23, 2025 08:40
@kim-mskw kim-mskw merged commit 971f652 into main Dec 23, 2025
7 of 9 checks passed
@kim-mskw kim-mskw deleted the rl_auto_obs_dim branch December 23, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants