-
Notifications
You must be signed in to change notification settings - Fork 30
Automatically calculate obs_dim based on foresight, unique_obs_dim, ... #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reward tuning now also mentioned in RenewableEnergyLearningSingleBidStrategy, also switched regret and reward calculation in EnergyLearningStrategy for readability
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
- Coverage 81.31% 81.30% -0.01%
==========================================
Files 54 54
Lines 8032 8035 +3
==========================================
+ Hits 6531 6533 +2
- Misses 1501 1502 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maurerle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I would like to also wait for feedback from @kim-mskw
kim-mskw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice work @reinecfi. Please adjust the learning notebooks as well; they won't be functional if I am correct, and even if they should reflect the current implementation. I added release notes, noting that any other rationale for the obs_dim needs to be reconfigured in the learning strategy. Please add this explanation to the learning notebook as well.
…esight is subject to change incorporated feedback from Isaac on the config file decription added a couple comments to adress what Chiara wondered about
|
The notebooks should be up to date now. |
- add obs_dim calcualtion explanation to 04b and 04c
Description
Currently obs_dim, foresight, unique_obs_dim are fixed values for a given strategy. As they are directly interdependent, obs_dim is now calculated based on the other ones. Adjustments should now only need less changes per strategy.
Also correcting some wrong values in the doc strings and removing the reward scaling in RenewableEnergyLearningSingleBidStrategy (as already done in EnergyLearningStrategy).
Checklist
docfolder updates etc.)