-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ty] support type[tuple[...]]
#21652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Was just about to comment about the typing conformance changes being identical to #21652.. but then I realized this PR was stacked on that one 😄 |
9cb60b3 to
03e7444
Compare
|
oops, I think I just accidentally left some review comments regarding changes that already landed in 77f8fa6 (I guess this needs to be rebased now that's landed 😄) |
630a684 to
40d66c3
Compare
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-type-arguments |
0 | 2 | 0 |
unsupported-base |
2 | 0 | 0 |
unused-ignore-comment |
1 | 0 | 0 |
| Total | 3 | 2 | 0 |
|
Re-running the ecosystem checks to pick up the changes in #21721. |
|
Thanks for updating and landing this and the previous PR in stack @sharkdp ! |
Fixes astral-sh/ty#1649
Summary
We missed this when adding support for
type[]of a specialized generic.Test Plan
Added mdtests.