-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ty] uniformly weak imports #21653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alex/submodule-attr-last
Are you sure you want to change the base?
[ty] uniformly weak imports #21653
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unresolved-attribute |
70 | 257 | 58 |
possibly-missing-attribute |
20 | 0 | 1 |
invalid-argument-type |
5 | 11 | 1 |
unsupported-operator |
6 | 0 | 0 |
invalid-assignment |
3 | 1 | 0 |
call-non-callable |
0 | 1 | 0 |
| Total | 104 | 270 | 60 |
|
Ayup, basically just rerolls where we mess up on pwndbg |
|
pwndbg explicitly shadows it's own submodule with This is basically the entire diff. Both in added diagnostics and removed diagnostics. Very potato-potatoh situation. pwndbg is messed up either way. I guess this is the motivating case but boy I sure wish they just had an |
|
The other changes are:
|
Split out from #21583 to analyze the effect of this one change.
The code in the base PR gives
import a.bhighest priority, whilefrom a.b import ...gets second-lowest priority (beating only__getattr__). This PR removes the special handling ofimport a.bso that they get the same priority asfrom a.b import....