Use python date format code instead of shelling out. #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Already pushed the import line fix. Would you like me to squash? |
|
I'd squash it, yes |
DanLipsitt
force-pushed
the
feature/native-822-date
branch
from
4c3e4fe to
0383e87
Compare
|
Squashed. |
dirk-thomas
reviewed
Oct 16, 2020
| args = [cmd,'-R'] | ||
| result = get_cmd_stdout(args).strip() | ||
| """return date string in rfc 822 format""" | ||
| result = formatdate() |
There was a problem hiding this comment.
Should this pass localtime=True to maintain the exact behavior of date -R?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
debianizeto run on MacOS (and probably other BSD-based platforms). The BSDdatecommand does not have the-Rflag previously used by this function.