Use GHA self-hoster runner for e2e/k8s science tests#1147
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CI/e2e pipeline to support running Kubernetes E2E tests on a GitHub Actions self-hosted runner, integrates home-ci-reporter for structured reporting, and adjusts image promotion/push behavior.
Changes:
- Add
home-ci-reporterinitialization/step reporting/finalization to the E2E runner script and improve E2E logging. - Update reusable GHA workflow to optionally skip artifact upload/download and instead persist the Docker image via a shared path for self-hosted runners.
- Update image push logic to handle promoted image tagging/pushing and fallback to
skopeo copy; bumpktbxdependency.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
push-image.sh |
Reworks image push/promotion logic and adds skopeo-based copy path. |
home-ci-oneshot.sh |
Adds a one-line helper to run home-ci with a fixed config/branch. |
e2e/run.sh |
Adds structured home-ci-reporter reporting and more phased logging; tweaks option parsing. |
e2e/clean.sh |
Adds a helper script to delete the e2e cluster. |
e2e/check-results.sh |
Improves failure logging/diagnostics while waiting for expected topics. |
build.sh |
Removes an obsolete TODO comment. |
TODO.org / TODO.latest / TODO.931 |
Minor TODO housekeeping (blank line added; old TODO files removed). |
.gitignore |
Ignores generated e2e-report.yaml. |
.github/workflows/e2e-k8s-ztf-science-self-hosted.yml |
Enables skip_artifacts for self-hosted E2E runs. |
.github/workflows/e2e-common.yml |
Implements skip_artifacts flow and shared-image-path handling; updates outputs. |
.github/workflows/dispatch.yaml |
Ensures E2E report parsing runs even when prior steps fail. |
.ciux |
Bumps ktbx to v1.1.6-rc5. |
Comments suppressed due to low confidence (1)
e2e/run.sh:83
- The usage string doesn’t document the
-S <storage>option, butgetoptsaccepts it and it’s used to setstorage(and passed toargocd.sh). Please update the help text so the CLI surface matches the implementation.
usage () {
echo "Usage: $0 [-c] [-h] [-m] [-s]"
echo " -s: Use the science algorithms during the tests"
echo " -c: Cleanup the cluster after the tests"
echo " -i: Specify input survey. Default: ztf"
echo " -m: Install monitoring stack"
echo " -h: Display this help"
echo ""
echo " Run fink-broker e2e tests, using source code from the parent directory."
exit 1
}
SUFFIX="noscience"
ciux_version=v0.0.7-rc1
src_dir=$DIR/..
cleanup=false
build=false
e2e=false
monitoring=false
push=false
storage="hdfs"
CIUX_IMAGE_URL="undefined"
input_survey="ztf"
token="${TOKEN:-}"
# Get options for suffix
while getopts hcmsi:S: opt; do
case ${opt} in
c )
cleanup=true
;;
h )
usage
exit 0
;;
m )
monitoring=true
;;
s )
SUFFIX=""
;;
i )
input_survey="$OPTARG"
;;
S) storage="$OPTARG" ;;
\? )
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1147 +/- ##
======================================
Coverage 62% 62%
======================================
Files 27 27
Lines 1887 1887
======================================
Hits 1180 1180
Misses 707 707 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JulienPeloton
left a comment
There was a problem hiding this comment.
Thank you @fjammes -- this is a great PR!
I left one comment, otherwise, good to merge.
Use home-ci/home-ci-reporter for e2e test Bump ktbx to v1.1.6-rc5 Bump down kind to v0.20.0 Add suffix option to push image script Use skopeo to manage image name Improve CIUX image name management Improve logging
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
e5199c2 to
28aeb71
Compare
|



Use home-ci/home-ci-reporter for e2e test
Bump ktbx to v1.1.6-rc5
Bump down kind to v0.20.0
Add suffix option to push image script
Use skopeo to manage image name
Improve CIUX image name management
Improve logging
IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #1131
What changes were proposed in this pull request?
How is the issue this PR is referenced against solved with this PR?
How was this patch tested?