Skip to content

enh: adding a criteria to have only candidates with minimum two points #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulienPeloton merged 6 commits into from
Apr 27, 2026
Merged

enh: adding a criteria to have only candidates with minimum two points #358

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
167ecc8
enh: adding a criteria to have only candidates with minimum two points
camilledzt Mar 11, 2026
5b77941
typo: missing =
camilledzt Mar 11, 2026
c24247c
enh: adding some criteria to the filter
camilledzt Mar 25, 2026
82f02ed
enh: adding some criteria to the filter
camilledzt Mar 25, 2026
2890988
enh: removing good quality block as it's already included in the b_ex…
camilledzt Apr 24, 2026
3357b55
update doc
camilledzt Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions fink_filters/rubin/livestream/filter_extragalactic_new_candidate/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Copyright 2019-2026 AstroLab Software
# Author: Julien Peloton
# Author: Julien Peloton, Camille Douzet
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -12,19 +12,18 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Select LSST alerts new (< 48h first apparition) and potentially extragalactic"""
"""Select LSST alerts new (< 48h first apparition with a minimum of 2 points) and potentially extragalactic"""

import pandas as pd
import fink_filters.rubin.blocks as fb

import fink_filters.rubin.blocks as fb

DESCRIPTION = (
"Select LSST alerts new (< 48h first apparition) and potentially extragalactic"
)
DESCRIPTION = "Select LSST alerts new (< 48h first apparition with a minimum of 2 points) and potentially extragalactic"


def extragalactic_new_candidate(
diaSource: pd.DataFrame,
diaObject: pd.DataFrame,
simbad_otype: pd.Series,
mangrove_lum_dist: pd.Series,
is_sso: pd.Series,
Expand All @@ -35,7 +34,7 @@ def extragalactic_new_candidate(
legacydr8_zphot: pd.Series,
firstDiaSourceMjdTaiFink: pd.Series,
) -> pd.Series:
"""Select LSST alerts new (< 48h first apparition) and potentially extragalactic
"""Select LSST alerts new (< 48h first apparition with a minimum of 2 points) and potentially extragalactic

Notes
-----
Expand Down Expand Up @@ -98,7 +97,10 @@ def extragalactic_new_candidate(
# 48h maximum
f_new = (diaSource.midpointMjdTai - firstDiaSourceMjdTaiFink) < 2.0

f_extragalactic_new = f_extragalactic_near_galaxy & f_new
# Minimum 2 points
f_sampling = diaObject.nDiaSources > 2
Comment thread
JulienPeloton marked this conversation as resolved.
Outdated

f_extragalactic_new = f_extragalactic_near_galaxy & f_new & f_sampling

return f_extragalactic_new

Expand Down
Loading