Update orphan GRB classifier model retrained with sklearn 1.5.2#684
Update orphan GRB classifier model retrained with sklearn 1.5.2#684sedlachevre wants to merge 3 commits intoastrolabsoftware:masterfrom
Conversation
|
Thank you @sedlachevre ! Could you uncomment this line in your fork: and push, to trigger the test suite on this module? |
|
@JulienPeloton I am a bit surprised by the error of the test-suite above: @sedlachevre, actually, the error above is not a blocker, the real issue is that we need to add the following import |
|
Yes, |
|
Thanks for the change -- looking at the continuous integration, the test on orphans is failing usinng previous setup: Is that expected? Can you inspect these 6 objects that have non-zero probability? |
|
I ran the test locally on the same data and I also got 6 objects with a non-zero probability but these probabilities are very small (p<0.00003). This is expected with our machine learning model and should not be a problem for orphan detection. Is it possible to only count objects with a probability higher than 0.1 instead of 0.0 ( |
|
Sure! You can update the test accordingly. |
IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #683 (comment)
If this is a new release, did you issue the corresponding schema in fink-client?
N/A
What changes were proposed in this pull request?
The orphan GRB afterglow classifier model was retrained with scikit-learn 1.5.2 to replace the old model which was incompatible with the current sklearn versions due to the removal of sklearn.ensemble._gb_losses in sklearn 1.0.
How is the issue this PR is referenced against solved with this PR?
How was this patch tested?
The new model was locally tested on a sample of 1915 simulated orphan afterglow light curves and 695195 events from the ELAsTiCC data set (playing the role of background) and showed great accuracy.