6789 git-sync volume support #556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de. Breakout logic into function.
pgvishnuram
reviewed
Jan 17, 2025
pgvishnuram
reviewed
Jan 17, 2025
| ## the git-sync-relay | ||
| volumeSync: | ||
| volumeSize: 10Gi | ||
| # The specified storageClassName must support ReadWriteMany |
There was a problem hiding this comment.
ReadWriteMany should this comment be removed in here
There was a problem hiding this comment.
That is a hint to the user. Actually, we have not been following the recommendations for documentation in helm charts, so maybe this is something we should improve? https://v2.helm.sh/docs/chart_best_practices/#document-values-yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add git-sync volume mode.
Related Issues
Testing
I've tested this manually. We'll need more comprehensive testing from QA since this is a new feature that will have astro-ui and houston components.
Merging
This is only meant for 0.37