Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular, per-pixel statistics method. #477

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Conversation

delucchi-cmu
Copy link
Contributor

See astronomy-commons/lsdb#550

Adds a method in HATS to get granular per-pixel statistics. This is really customizable, to reduce the size of the returned object in case there are many pixels or many columns (or both).

Extracts some shared logic with the similar aggregate_column_statistics method.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 91.22807% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.11%. Comparing base (a30cd8e) to head (ec1bc32).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hats/catalog/dataset/dataset.py 33.33% 4 Missing ⚠️
src/hats/io/parquet_metadata.py 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   92.16%   92.11%   -0.06%     
==========================================
  Files          47       47              
  Lines        1953     2003      +50     
==========================================
+ Hits         1800     1845      +45     
- Misses        153      158       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 20, 2025

Before [a30cd8e] <v0.5.0> After [49eb922] Ratio Benchmark (Parameter)
1.03±0.03ms 1.05±0.02ms 1.01 benchmarks.time_test_cone_filter_multiple_order
106±0.2ms 106±0.7ms 1 benchmarks.time_test_alignment_even_sky
39.6±0.8ms 39.3±0.5ms 0.99 benchmarks.Suite.time_pixel_tree_creation
12.5±0.2ms 12.2±0.3ms 0.98 benchmarks.Suite.time_inner_pixel_alignment
357±4ms 349±2ms 0.98 benchmarks.Suite.time_outer_pixel_alignment
78.9±6ms 73.5±0.4ms 0.93 benchmarks.MetadataSuite.time_load_partition_info_order7
20.8±2ms 18.5±0.08ms 0.89 benchmarks.MetadataSuite.time_load_partition_info_order6
81.9±5ms 72.9±0.3ms 0.89 benchmarks.MetadataSuite.time_load_partition_join_info

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu requested a review from OliviaLynn March 20, 2025 17:46
Copy link
Member

@OliviaLynn OliviaLynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

@delucchi-cmu delucchi-cmu merged commit 919981d into main Mar 20, 2025
10 of 12 checks passed
@delucchi-cmu delucchi-cmu deleted the lsdb/issue/550/per_pixel branch March 20, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants