Skip to content

BUG: pass on environment variables to CI and revert skipping OSX tests#733

Merged
bsipocz merged 5 commits intoastropy:mainfrom
bsipocz:BUG_pass_on_env_to_CI
Feb 27, 2026
Merged

BUG: pass on environment variables to CI and revert skipping OSX tests#733
bsipocz merged 5 commits intoastropy:mainfrom
bsipocz:BUG_pass_on_env_to_CI

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Feb 23, 2026

I separated this one out from #732, so the other one can be backported if needed. The changes here need only affect 1.9 along with the SAMP module.

This works around #731, but I am not convinced that we don't have an actual problem (though I don't see these errors locally on an OSX, they are very consistent for CI)

@bsipocz bsipocz force-pushed the BUG_pass_on_env_to_CI branch from 9ec9c2b to ced6974 Compare February 23, 2026 22:20
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.43%. Comparing base (c813d4a) to head (23dfb41).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   82.62%   79.43%   -3.20%     
==========================================
  Files          91       91              
  Lines       10287    10287              
==========================================
- Hits         8500     8171     -329     
- Misses       1787     2116     +329     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz merged commit ea641d6 into astropy:main Feb 27, 2026
12 of 13 checks passed
@bsipocz bsipocz deleted the BUG_pass_on_env_to_CI branch February 27, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant