Add support for Termux (Android) #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioistired
reviewed
Oct 15, 2017
| @@ -79,6 +79,8 @@ def determine_clipboard(): | |||
| return init_xsel_clipboard() | |||
| if _executable_exists("klipper") and _executable_exists("qdbus"): | |||
| return init_klipper_clipboard() | |||
| if _executable_exists("termux-clipboard-get") and _executable_exists("termux-clipboard-set"): | |||
There was a problem hiding this comment.
HAS_DISPLAY is False on Android. This should be as an elif to the HAS_DISPLAY check.
|
Oh wow, I should've checked the PRs before I opened #105 😛 Anyway, my fork doesn't have the bug I commented on above, so if you'd like to close this or fix that bug, that'd be great. If you fix it in your patch I'll close my PR. |
|
It's alright, thank you for including the feature as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test with random whitespaces fails though :(
Not sure if
termux-clipboard-[gs]etactually supports it. I understand if this can't be merged due to having a test failing :P