add local reporter, unit and integration tests#25
Merged
Conversation
arielb1
force-pushed
the
integration-2
branch
30 times, most recently
from
251beb0 to
0501fa2
Compare
arielb1
changed the title
arielb1
changed the title
jlizen
reviewed
Apr 24, 2025
| .to_rfc3339_opts(SecondsFormat::Secs, true) | ||
| .replace(":", "-"); | ||
| let file_name = format!("{time}.jfr"); | ||
| tokio::fs::write(self.directory.join(file_name), jfr).await?; |
Collaborator
There was a problem hiding this comment.
tracing::debug! statement might be nice
jlizen
reviewed
Apr 24, 2025
jlizen
reviewed
Apr 24, 2025
jlizen
reviewed
Apr 24, 2025
Collaborator
jlizen
left a comment
jlizen
left a comment
There was a problem hiding this comment.
Let's also mention LocalReporter (and MultiReporter) support in the README
jlizen
reviewed
Apr 24, 2025
jlizen
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📬 Issue #, if available:
Fixes #19
✍️ Description of changes:
🔏 By submitting this pull request