Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed social network example #251

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

sudoshreyansh
Copy link
Contributor

Description

  • Migrated to ESM Modules
  • Disabled functions.test.ts
  • Tested dynamic imports in windows and linux

Related issue(s)
Resolves #239

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented Feb 14, 2022

Pull Request Test Coverage Report for Build 1839702106

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+19.9%) to 79.57%

Totals Coverage Status
Change from base Build 1830280688: 19.9%
Covered Lines: 232
Relevant Lines: 276

💛 - Coveralls

@fmvilas
Copy link
Member

fmvilas commented Feb 14, 2022

I found two issues:

Examples not running

I'm getting this error while trying to run the websocket-server or any other example:

$ npm run dev

> [email protected] dev /Users/fmvilas/www/glee/examples/social-network/websocket-server
> glee dev

internal/process/esm_loader.js:74
    internalBinding('errors').triggerUncaughtException(
                              ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/fmvilas/www/glee/dist/lib/compiler' imported from /Users/fmvilas/www/glee/dist/cli/index.js
    at finalizeResolution (internal/modules/esm/resolve.js:276:11)
    at moduleResolve (internal/modules/esm/resolve.js:699:10)
    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:810:11)
    at Loader.resolve (internal/modules/esm/loader.js:85:40)
    at Loader.getModuleJob (internal/modules/esm/loader.js:229:28)
    at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:51:40)
    at link (internal/modules/esm/module_job.js:50:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}

Any hints? I cleared node_modules, removed package-lock.json, and reinstalled everything but nothing works :/

Tests for functions.ts file

The tests included in functions.test.ts are not being executed when I run npm test. Any idea?

@fmvilas
Copy link
Member

fmvilas commented Feb 14, 2022

Forget about the functions.test.ts stuff. I just saw you're ignoring it on purpose 👍

@sudoshreyansh
Copy link
Contributor Author

sudoshreyansh commented Feb 14, 2022

@fmvilas Maybe you didn't build glee?

@fmvilas
Copy link
Member

fmvilas commented Feb 17, 2022

You're right 🤦 Too many years using raw JS 😄

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @sudoshreyansh 👏

@fmvilas
Copy link
Member

fmvilas commented Feb 17, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 036ed6c into asyncapi:master Feb 17, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social network example is failing
4 participants