Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved inheritance handling for the Java Generator #2148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jessewb786
Copy link

@Jessewb786 Jessewb786 commented Jan 20, 2025

feat: Improved inheritance handling for the Java Generator.
test: Test has been extended to cover the new inheritance rule.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit a6e7502
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/678ecf0db514e40008509400

@Jessewb786 Jessewb786 force-pushed the feat-improve-java-inheritance branch from d7fd84b to a6e7502 Compare January 20, 2025 22:32
@Jessewb786 Jessewb786 changed the title Improve inheritance handling to include extension for intermediate in… feat: Improved inheritance handling for the Java Generator Jan 20, 2025
@Jessewb786
Copy link
Author

@kennethaasan and @jonaslagoni I see that you guys have worked on this part of the code in the past and I wonder if you could review this PR.
The gist of it is that modelina was not using the 'extends' for intermediate classes and now it does. The change is minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant