fix(ci): enable homebrew-tap auto-update and keep VERSION in sync#15
Merged
fix(ci): enable homebrew-tap auto-update and keep VERSION in sync#15
Conversation
Three small fixes so brew install atani/tap/gh-attach consistently pulls in the latest release. 1. Use the correct secret name for the homebrew-tap token. The repo secret is HOMEBREW_TAP_GITHUB_TOKEN, but the workflow referenced HOMEBREW_TAP_TOKEN, so the homebrew formula update job has been silently failing for every release. Align the reference. 2. Sync the bash VERSION string in bin/gh-attach with the tag the workflow is about to create. Without this the string drifts behind the git tag on every release, so gh-attach --version reports stale numbers (noticed 0.7.0 shipped inside the v0.7.1 tarball). 3. Bump VERSION to 0.7.1 manually to catch up with the current tag. Extend the skip condition so commits by github-actions[bot] do not re-trigger the workflow. Otherwise the VERSION-sync push would cause an infinite bump loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes so
brew install atani/tap/gh-attachconsistently pulls in the latest release.HOMEBREW_TAP_TOKENbut the repo secret isHOMEBREW_TAP_GITHUB_TOKEN, so the update-homebrew job has been silently failing on every release. Align the reference.VERSIONwith git tag. Add a workflow step that rewritesbin/gh-attach'sVERSION="..."to match the tag the workflow is about to create, sogh-attach --versionreports the real version (today v0.7.1 tarball containsVERSION="0.7.0").github-actions[bot]commits, otherwise the VERSION-sync push the workflow performs would re-trigger the workflow.Also bumps VERSION to 0.7.1 manually as a one-time catch-up.
Test plan
git diffshows only the three intended changesVERSION="0.7.2"