Add direct upload mode for configurable hosts#9
Merged
Conversation
file-attachment component + curl hybrid upload produces user-attachments URLs without release artifacts. - Add direct mode using upload policies API via browser auth and curl - Add --browser flag to force browser mode - Read ~/.config/gh-attach/config for direct_hosts setting - Update README with direct mode documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.config/gh-attach/config) で指定したホストに対して、direct upload mode を自動適用user-attachmentsURL を生成（Release アセットを作らない）--browserフラグで従来の browser mode に強制切り替え可能動作フロー (Direct mode)
user-attachmentsURL を取得Test plan
direct_hostsに登録した GHE ホストで direct mode が動作することを確認user-attachmentsURL で画像が埋め込まれることを確認--browserフラグで browser mode にフォールバックできることを確認--releaseフラグで release mode が動作することを確認