Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #14

Merged
merged 2 commits into from
Jul 13, 2018
Merged

Improve README #14

merged 2 commits into from
Jul 13, 2018

Conversation

CorreyL
Copy link
Contributor

@CorreyL CorreyL commented Jul 13, 2018

Hello @ATF19,

The following PR looks to improve the README.md file of react-native-shop-ui by moving the screenshots to a separate README.md file to lessen the amount users have to scroll to get to the rest of your README.md file. Additionally, I've added the specific instructions needed to run this application.

In the interest of full transparency, this edit is for an assignment for a university technical writing course. A higher grade will be rewarded if PRs are approved. Please let me know if there are any issues with this PR that could be rectified, or any further additions I can make, in order to achieve an approval.

Additionally, I can fill out the Documentation section of the main README.md file if you can provide more details on what you would like to be written there =)

Correy Lim and others added 2 commits July 12, 2018 19:16
Screenshots on the front page README would require the user to scroll
quite a bit to see the rest of the README, where the future
Documentation section would be filled out.

Moving the screenshots to their own README file and linking to it from
the front-page README will alleviate this issue
Replace installation section with the commands needed to install and run the codebase
@ATF19 ATF19 merged commit ae2f830 into atef-najar:master Jul 13, 2018
@ATF19
Copy link
Collaborator

ATF19 commented Jul 13, 2018

Hello,

It will be greatly helpful if you can post how to use and update the app code in the documentation section.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants