Skip to content

Conversation

Aryamanz29
Copy link
Member

  • Fixed an issue where deserialization of Purpose assets failed with a ValueError when encountering deleted or non-existent AtlanTagName in the purposeClassifications attribute.
  • Updated logic to replace invalid or deleted tags with a sentinel object instead of raising a ValueError, ensuring smoother deserialization.

Error example:

__root__ -> 9 -> detail -> attributes -> purposeClassifications -> 0
zXjPUQ4QJQwukO6KuWmZZA is not a valid AtlanTag (type=value_error).
Suggestion: Atlan was unable to produce a valid response to your request.
Please verify your request is valid.

This fix improves the resilience of the deserialization process by providing a fallback for invalid tags.

@Aryamanz29 Aryamanz29 added the bugfix Bug fix pull request label Jan 21, 2025
@Aryamanz29 Aryamanz29 self-assigned this Jan 21, 2025
…et deserialization

- Fixed an issue where deserialization of `Purpose` assets failed with a `ValueError` when encountering deleted or non-existent `AtlanTagName` in the `purposeClassifications` attribute.
- Updated logic to replace invalid or deleted tags with a sentinel object instead of raising an error, ensuring smoother deserialization.

Error example:

```py
__root__ -> 9 -> detail -> attributes -> purposeClassifications -> 0
zXjPUQ4QJQwukO6KuWmZZA is not a valid AtlanTag (type=value_error).
Suggestion: Atlan was unable to produce a valid response to your request.
Please verify your request is valid.
```

This fix improves the resilience of the deserialization process by providing a fallback for invalid tags.
Copy link
Contributor

@ErnestoLoma ErnestoLoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aryamanz29 Aryamanz29 merged commit 2219cf4 into main Jan 21, 2025
44 of 45 checks passed
@Aryamanz29 Aryamanz29 deleted the APP-4781 branch January 21, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants