Conversation
- Add announcement_expired_at: Optional[datetime] to Announcement dataclass - Add announcement_expired_at field to Asset.Attributes - Add property getter/setter on Asset - Wire through set_announcement(), get_announcment(), and Attributes.remove_announcement() Resolves DES-1500 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Greptile SummaryThis PR adds optional expiration date support to announcement API through the Key Changes
Implementation Quality
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| pyatlan/model/core.py | Added optional announcement_expired_at datetime field to Announcement dataclass with proper imports and default value |
| pyatlan/model/assets/core/asset.py | Integrated announcement_expired_at throughout asset model - added to attributes, fetch list, property getter/setter, and all announcement methods |
Last reviewed commit: 1bc740a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
announcement_expired_atsupport to the announcement API, matching the new field added to the Atlan platform in DES-1500.Changes
pyatlan/model/core.pyfrom datetime import datetimeimportannouncement_expired_at: Optional[datetime]field toAnnouncementdataclass (optional, defaults toNone— fully backward compatible)pyatlan/model/assets/core/asset.pyannouncement_expired_at: Optional[datetime]toAsset.Attributesannouncement_expired_atto the attribute fetch list (required for the field to be populated when loading assets from the API)Assetset_announcement()to set the fieldget_announcment()to return the fieldAttributes.remove_announcement()to null the fieldUsage
Test plan
Announcementcan be created withoutannouncement_expired_atset_announcement()/get_announcment()round-trip preservesannouncement_expired_atremove_announcement()clearsannouncement_expired_at🤖 Generated with Claude Code