Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-445 | Convert domain to subdomain #4449

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Conversation

ankitpatnaik-atlan
Copy link
Collaborator

@ankitpatnaik-atlan ankitpatnaik-atlan commented Mar 12, 2025

Change description

Convert a domain to a subdomain so that the superdomain can be moved in drag and drop in the product sidebar just like subdomain and data products.

Test Doc - doc

JIRA: MESH-445

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Copy link

github-actions bot commented Mar 18, 2025

Integration Test Results

✅ No failures in: AnaplanAssetTest
✅ No failures in: LinkTest
❌ Failures found in: AtlanTagTest (1 failures)
✅ No failures in: DataStudioAssetTest
✅ No failures in: KafkaTest
✅ No failures in: CubeTest
✅ No failures in: ConnectionTest
✅ No failures in: S3AssetTest
✅ No failures in: CustomAssetTest
✅ No failures in: DataverseAssetTest
✅ No failures in: AppAssetTest
✅ No failures in: LineageTest
✅ No failures in: SuggestionsTest
✅ No failures in: APIAssetTest
✅ No failures in: SupersetAssetTest
✅ No failures in: GCSAssetTest
✅ No failures in: SQLAssetTest
✅ No failures in: ResourceTest
✅ No failures in: ADLSAssetTest
✅ No failures in: QueryParserTest
✅ No failures in: AirflowAssetTest
✅ No failures in: CustomMetadataTest
✅ No failures in: GlossaryTest
✅ No failures in: AzureEventHubTest
✅ No failures in: FileTest
✅ No failures in: WorkflowTest
✅ No failures in: PresetAssetTest

Some tests failed or results were missing. Total failures: 1

@ankitpatnaik-atlan ankitpatnaik-atlan merged commit a1c2b98 into staging Mar 19, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants