Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xattr config and alpine tools dependency #160

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

iggy
Copy link
Contributor

@iggy iggy commented Feb 5, 2024

  • Remove the old way of handling configuration via xattrs
    • this seemed clever at the time and it worked fine, but it was finicky and there really aren't great tools for copying that around (despite what some utils say, they just didn't work as expected)
    • move to a new way of keeping config in separate directory structure
    • static files are still separate, so they can still be served via any web server
  • Remove alpine tools dependency
    • we now use the alpine go package to handle generating apkindexes
    • no longer requires having apk and abuild-sign binaries available
  • Reorganize the directory and URL structure
    • the above changes requires some minor changes to the dir/url structure
    • you know me, while I was there...

Copy link

github-actions bot commented Feb 5, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.52s
✅ COPYPASTE jscpd yes no 1.74s
✅ DOCKERFILE hadolint 1 0 0.13s
✅ GO golangci-lint yes yes no 39.61s
✅ GO revive yes no 0.03s
✅ MARKDOWN markdownlint 2 0 0 0.58s
✅ MARKDOWN markdown-link-check 2 0 0.53s
✅ MARKDOWN markdown-table-formatter 2 0 0 0.37s
✅ OPENAPI spectral 2 0 4.26s
✅ REPOSITORY checkov yes no 24.08s
✅ REPOSITORY gitleaks yes no 0.15s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 20.74s
✅ REPOSITORY secretlint yes no 1.36s
✅ REPOSITORY trivy yes no 18.19s
✅ REPOSITORY trivy-sbom yes no 7.88s
✅ REPOSITORY trufflehog yes no 8.34s
⚠️ SPELL lychee 12 3 0.36s
✅ YAML prettier 10 0 0 1.04s
✅ YAML v8r 10 0 7.96s
✅ YAML yamllint 10 0 0.58s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

* Remove the old way of handling configuration via xattrs
	* this seemed clever at the time and it worked fine, but it was
		finicky and there really aren't great tools for copying that around
		(despite what some utils say, they just didn't work as expected)
	* move to a new way of keeping config in separate directory structure
	* static files are still separate, so they can still be served via
		any web server
* Remove alpine tools dependency
	* we now use the alpine go package to handle generating apkindexes
	* no longer requires having apk and abuild-sign binaries available
* Reorganize the directory and URL structure
	* the above changes requires some minor changes to the dir/url
		structure
	* you know me, while I was there...
@iggy iggy force-pushed the remove-xattrs-apk-tools branch from a5a0555 to bef043c Compare February 5, 2024 01:43
@iggy iggy merged commit 47148ff into main Feb 5, 2024
3 checks passed
@iggy iggy deleted the remove-xattrs-apk-tools branch February 5, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant