Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confluence api v2 and Jira api v3 added #1522

Open
wants to merge 52 commits into
base: master
Choose a base branch
from

Conversation

batzel
Copy link

@batzel batzel commented Apr 3, 2025

I've added confluence v2 and jira v3, for the newer Atlassian Cloud servers. Unit tests and integration tests against live servers, flake8 and black to clean up the code, and I'm using it now with mcp-atlassian.

batzel-upenn and others added 30 commits April 3, 2025 14:50
…o v3. You must be an expert Python programmer. We will use the confluence-v2-implementation to decide how to do things -- we should do things the same way where possible. To begin, then, we should look at the current codebase's jira functionality and at the REST API documentation at https://developer.atlassian.com/cloud/ for jira cloud platform, then later jira software cloud, then later still jira service management cloud. We should maintain as much backward-compatible code as we possibly can to avoid breaking users of earlier jira APIs. Look at the confluence_v2_implementation_checklist.md file and at the codebase for confluence v2. We must begin with the implementation checklist, and it must include a new directory under atlassian/ for the new version of the jira api.
batzel added 22 commits April 3, 2025 14:53
…pecific pagination tests, permission handling tests, and Python version compatibility tests.
…e API architecture, specialized clients, ADF support, pagination, error handling, offline tests, and documentation
@gonchik
Copy link
Member

gonchik commented Apr 3, 2025

@batzel @batzel-upenn why do you add into 1 merge request 2 different wrapers ?
I see many other files are changed.
could you make changes more atomic and small bunches please ?
Code review is starting to be very complicated, as I previous code I did not read fully yet

Copy link
Member

@gonchik gonchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not needed

@batzel
Copy link
Author

batzel commented Apr 3, 2025

Sorry, I'm a bit new at working with public repos. My main goal was getting the code working for me. I can separate things out into several requests if you want it that way. Can you suggest how you'd like me to break it into sections? I don't mean to cause you trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants