Fix compiled css filename#1925
Draft
xtan-atlas wants to merge 3 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 9679672 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for compiled-css-in-js canceled.
|
JakeLane
reviewed
Jul 23, 2026
| } | ||
|
|
||
| const cssFileName = basename(bundle.displayName, '.html') + '.' + hash(stylesheet) + '.css'; | ||
| const cssFileName = 'compiled.' + hash(stylesheet) + '.css'; |
Collaborator
There was a problem hiding this comment.
this will cause collisions if you have a new entry. Maybe something like:
Suggested change
| const cssFileName = 'compiled.' + hash(stylesheet) + '.css'; | |
| const cssFileName = 'compiled.' + basename(bundle.displayName, '.html') + hash(stylesheet) + '.css'; |
or a configurable filename?
Contributor
Author
There was a problem hiding this comment.
configurable filename would be better, I guess from parcelrc. If you don't mind I will leave it to you to do it properly :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change?
change compiled css file name to 'compiled.' + hash(stylesheet) + '.css'
Why are we making this change?
Predictable file name pattern allows upstream to control whether to inline or not
How are we making this change?
(Optional.)
PR checklist
Don't delete me!
I have...
website/