Add coordinate factory method for SDL definitions - #720
Merged
Conversation
gnawf
changed the title
gnawf
force-pushed
the
schema-definition-coordinates-factory
branch
2 times, most recently
from
March 17, 2026 05:23
21dc795 to
b9e91c9
Compare
gnawf
marked this pull request as ready for review
March 17, 2026 05:23
gnawf
commented
Mar 17, 2026
| return true | ||
| } | ||
| } | ||
| NadelSchemaCoordinateCollectorTraverserVisitor(coordinates), |
Collaborator
Author
There was a problem hiding this comment.
Extracted existing code to separate class
bbakerman
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #719
Allows us to read SDL definitions that are semantically invalid but syntactically valid.