add QR code generator for pydropsonde#211
Draft
tmieslinger wants to merge 1 commit intoatmdrops:mainfrom
Draft
Conversation
Collaborator
Author
|
@d70-t do you have an idea on the svg handling? Or maybe the whole idea of an automatically generated QR code doesn't make sense and should be dropped entirely? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought of adding a script that generates a QR code pointing to
pydropsonde.At this stage, only the default works well, the optional logo embedded as image in the QR code does not work yet as I couldn't find an elegant way to convert
svgimages to a format that pillow can handle (currently it's assumed that imagemagick is installed on your machine) and also, the current default logo is too large and covers the full QR code.If someone has an idea, let me know :)
Maybe it would be even nice to include such a script in the workflows and point to e.g. the latest release?