Open
Conversation
…concat_circle functions respectively. And 4 new files added which are to be removed
…te_and_populate_flight_object, to check if their output is empty or not. turns out they are empty!"
…fied for EUREC4A needs. pipeline.py - create_and_populate_circle_object , the print and saving statement updated.
… processor.py - generalised finding flight_id for P3 and HALO
…ad A- files in all functions doing so 2) In processor.py - modified get_circle_times_from_segmentation() for eurec4a data, it won't work on orchestra.
Collaborator
|
Thank you for testing
Overall, this was a super helpful test and I would appreciate if you add the eurec4a config to the linked repo and open a PR there. Thanks again for all the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have modified some of the files so as process EUREC4A's HALO level 0 data using Pydropsonde. The first change mentioned needs to be generalized so both EUREC4A and ORCESTRA can be processed simultaneously.
Changed in processor.py - modified the method get_circle_times_from_segementation() so it the 'flight_id' corresponds to 'flight_id's in EUREC4A's flight segmentation file (Type - 'Platform-MMDD'). They are not the same as flight id which pydropsonde derives from Level 0 data (type - 'YYYYMMDD'). So this change may end up not working for orcestra. This needs to be generalized, so both orchestra and eurec4a can be processed using same code.
Change in rawreader.py - modified opening and reading of A-files. Earlier it stirctly only read characters of type UTF-8, just changed that if a non-utf-8 , character comes, ignore the error and proceed. (this problem was in P3 files, and on making this change, it magically worked - until another error came).
Added 2 more files relevant for EUREC4A- segmentation file and config file I made (path needs to be modified)
Thank you
Chitvan Singh