This repository was archived by the owner on Dec 15, 2022. It is now read-only.
use path.join #1221
Merged
use path.join #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winstliu
reviewed
Feb 2, 2018
lib/tree-view.coffee
Outdated
|
|
||
| entryName = path.basename(initialPath) | ||
| newPath = "#{newDirectoryPath}/#{entryName}".replace(/\s+$/, '') | ||
| newPath = path.join(newDirectoryPath, entryName).replace(/\s+$/, '') |
Contributor
There was a problem hiding this comment.
I also don't think the replace is necessary. I haven't seen any other case where we trim paths.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
use path.join instead of hard coding a slash
Applicable Issues
#1179 (comment)