This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix default location getter #1350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Renames
getPreferredLocationtogetDefaultLocation. The former was introduced in #1056, but the Dock API uses the latter. I don't know if the error was an oversight, or if the API itself changed since then.There are no references to
getPreferredLocationin this code base otherwise. The config value itself is intentionally not advertised, as per #1056 (comment). It was probably intended to be removed at some point, but this PR is just meant to fix the method name, nothing more.No tests, there were none before and I don't see a point in testing how the Dock controller behaves.
Alternate Designs
NA
Benefits
Get's picked up by Dock API.
Possible Drawbacks
NA
Applicable Issues
Was brought up in https://discuss.atom.io/t/tree-view-on-the-right-side/76834