This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Reset drag counts when dropping #851
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an entry is dropped in a directory, reset that directories drag counts. The drag count is only decremented on a dragLeave event, which never happens with onDrop events.
|
Noticed this bug when testing #793. Tested this PR and it fixes the problem for me. |
|
@50wliu i think so. I don't see this bug any longer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, behavior in Atom 1.7.4 looks like this:
after an entry is dropped on a directory, that directory can no longer become
.selectedondragEnterevents.this PR resets the
dragEventCountsvalue for that directory so that subsequentdragEnterevents give it the.selectedclass.i'm having a hard time replicating the broken behavior in specs, which may have something to do with how drag events are being built