Fix MINIO_*_KEY deprecation warning and make server config more customizable #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about 4 months ago minio introduced a change that deprecated the variables MINIO_ACCESS_KEY and MINIO_SECRET_KEY and replaced them with MINIO_ROOT_USER and MINIO_ROOT_PASSWORD respectively. internally they are handled the same
this non-breaking change works well, because ansible users can just replace their variables and it still works without having to restart or redeploy the whole infra stack. (most likely)
during deployment we found that being able to set the
minio_server_addrwasn't detailed enough, it's nice to split it into port + ip/fqdn