feat: libs #166
Draft
feat: libs #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sugyan
commented
May 2, 2024
sugyan
commented
- common-web
- crypto
- identity
str4d
reviewed
May 7, 2024
Contributor
There was a problem hiding this comment.
These types already exist in atrium_api::did_doc (and look almost identical, other than missing the context field on DidDocument). Is the plan to move these types out of atrium-api, or is this just a temporary duplication as part of figuring out where atrium-libs sits in the crate dependency tree?
Member
Author
There was a problem hiding this comment.
Thanks for taking a look!
Yes, currently I am thinking of removing atrium_api::did_doc and referencing common_web::did_doc from the api by adding these new libs.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.