Skip to content

Conversation

elfmimi
Copy link

@elfmimi elfmimi commented Aug 17, 2025

Prior to the fix:

  • USB enumeration was quite unreliable especially on Windows.
  • usb_serial_echo.rs example was occasionally dropping characters.
  • usbreset command on Linux was unresponsive and in most cases BUS/DEV number differs after reset.

Copy link
Collaborator

@michalfita michalfita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please comment changes better. The original code comes from Grepit and had been battle tested to certain extend, but as we're getting extra hands on these, this aspect needs improvement.

@martinmortsell would you have chance to test this in any way?

@tmplt
Copy link
Member

tmplt commented Aug 24, 2025

Glad to see this module getting some much-needed love!

From a brief look I recommend more documentation (in general), but perhaps a layer of abstraction above the register modifications. My knowledge of USB and the peripheral itself has bit-rotted, so I cannot help in review efforts, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants