Skip to content

Conversation

@mtpauly
Copy link
Contributor

@mtpauly mtpauly commented Aug 5, 2025

Update review behavior: enforce inline comments and concise summary

This change updates our review prompts and documentation to prioritize line-anchored inline comments for code-specific feedback and to keep the top-level review summary brief and non-actionable.

Why

Reduce sprawling top-level comments and drive concrete, actionable suggestions directly onto the relevant lines, improving clarity, adoption, and signal-to-noise in reviews.

What’s changed

  • Enforce inline comments for any code-specific issue; when proposing code, use GitHub suggestion blocks to provide minimal, accurate patches.
  • Restrict the top-level summary to at most three sentences with no code blocks, code suggestions, or file/line references; avoid repeating details from inline comments.
  • Shift guidance from grouping feedback to one comment per distinct issue/location; for issues spanning multiple locations, post separate inline comments and indicate they’re related.
  • Clarify formatting expectations: prefer suggestion blocks in inline comments; do not include code in the summary.
  • Revise README "How It Works" to describe submitting a single GitHub review with a brief summary plus multiple inline comments, rather than editing the PR description.

Impact

  • More precise, actionable reviews that map directly to code changes.
  • Reduced noise in top-level summaries; improved reviewer and author experience.
  • No changes to permissions or workflows; backward compatible.

🤖 This description was generated automatically. Please react with 👍 if it's helpful or 👎 if it needs improvement.

… keep summary brief and non-actionable; adjust formatting and README to reflect inline review flow
@mtpauly mtpauly requested a review from nathro August 5, 2025 20:49
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shift to inline, line-anchored comments with a brief, non-actionable summary looks solid and should reduce top-level noise. I left a couple of small wording tweaks to make the guidance fully explicit and consistent across templates and README.


🤖 Automated review complete. Please react with 👍 or 👎 on the individual review comments to provide feedback on their usefulness.

- Use code blocks for multi-line code examples
- Include file paths and line numbers when referencing specific code locations
- In inline review comments, prefer GitHub suggestion blocks (```suggestion) for concrete code changes; ensure patches are minimal and accurate
- Do not include code blocks or specific code suggestions in the top-level review summary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording/clarity: consider showing the full fence so readers see the expected form of a suggestion block (open and close). For example: ("```suggestion ... ```")

4. **AI Processing**: Calls the Augment Agent to analyze the changes and generate a review
5. **PR Update**: The Augment Agent updates the PR description with the generated review content
5. **PR Review Submission**: The Augment Agent submits a single GitHub review containing a brief summary and multiple inline comments anchored to specific lines in the PR diff (including suggestion blocks where appropriate)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: to be explicit/consistent with the templates, call these GitHub suggestion blocks.

Suggested change
5. **PR Review Submission**: The Augment Agent submits a single GitHub review containing a brief summary and multiple inline comments anchored to specific lines in the PR diff (including GitHub suggestion blocks where appropriate)

- Do not post comments outside of the single review
- For any code-specific issue, you MUST post an inline review comment anchored to the exact file and line in the PR diff; when proposing code changes, use GitHub suggestion blocks (```suggestion ... ```)
- The review summary MUST be at most 3 sentences and MUST NOT include code-specific suggestions, code blocks, or file/line references. Do not repeat details from inline comments.
- Submit a single GitHub review containing your inline comments plus the brief summary. Do not create multiple reviews.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny consistency tweak to match the phrasing used elsewhere ("top-level review summary").

Suggested change
- Submit a single GitHub review containing your inline comments plus the brief summary. Do not create multiple reviews.
- The top-level review summary MUST be at most 3 sentences and MUST NOT include code-specific suggestions, code blocks, or file/line references. Do not repeat details from inline comments.

@mtpauly mtpauly merged commit 6b474cf into main Aug 6, 2025
3 checks passed
@mtpauly mtpauly deleted the chore/enforce-inline-review-comments branch August 6, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants