Remove rules and mcp_configs input parameters #12
Conversation
- Remove rules and mcp_configs inputs from action.yml - Update README.md to remove documentation for these parameters - Downgrade version from 0.1.4 to 0.1.3 in package.json This change simplifies the action by removing the ability to forward custom rules and MCP config files to the augment agent.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The removal of rules and mcp_configs parameters is clean and consistent across all files. However, there's a semantic versioning concern with the version change that should be addressed.
🤖 Automated review complete. Please react with 👍 or 👎 on the individual review comments to provide feedback on their usefulness.
| { | ||
| "name": "augment-review-pr", | ||
| "version": "0.1.4", | ||
| "version": "0.1.3", |
There was a problem hiding this comment.
Semantic Versioning Concern: Downgrading from version 0.1.4 to 0.1.3 violates semantic versioning principles. Version 0.1.4 has already been released (commit 866c166), and downgrading to a previous version number can cause confusion and conflicts for users who may have already adopted 0.1.4.
Recommended approach:
- Bump to 0.1.5 if this is a patch-level change (bug fix/minor improvement)
- Bump to 0.2.0 if removing these parameters is considered a breaking change for users who were using them
Since this PR removes functionality that users may depend on, version 0.2.0 would be more appropriate to signal the breaking change.
Current code:
"version": "0.1.3",Suggested improvement:
"version": "0.2.0",![augment-app-staging[bot]](https://avatars.githubusercontent.com/in/1008152?s=60&v=4){kind=small}
Remove
rulesandmcp_configsinput parameters from GitHub ActionThis PR simplifies the action interface by removing two optional input parameters that are no longer supported in the underlying augment-agent:
rulesinput: Eliminates the ability to pass custom rule file paths to the augment agentmcp_configsinput: Eliminates the ability to pass MCP configuration file paths to the augment agentThese changes align with upstream changes in augment-agent PR #9. Users who previously relied on these parameters will need to use alternative configuration methods.
🤖 This description was generated automatically. Please react with 👍 if it's helpful or 👎 if it needs improvement.